cmdmon: refactor handling of sources report

The NSR_ReportSource() and RCL_ReportSource() functions assume that the
provided report already has some data prefilled by SRC_ReportSource()
and it's assumed these functions cannot fail.

Change them to accept the required data (refid and IP address) as
a parameter, remove unneeded parameters, and return an error status
(if the refid/address doesn't exist) to be handled in cmdmon
handle_source_data(). Also, catch unexpected values of the source state
and mode to make chronyc report an error instead of incorrect data.
This commit is contained in:
Miroslav Lichvar
2025-11-19 14:12:09 +01:00
parent 662484cd0a
commit 0fec9e5cfa
8 changed files with 32 additions and 28 deletions

View File

@@ -3098,7 +3098,7 @@ NCR_InitiateSampleBurst(NCR_Instance inst, int n_good_samples, int n_total_sampl
/* ================================================== */
void
NCR_ReportSource(NCR_Instance inst, RPT_SourceReport *report, struct timespec *now)
NCR_ReportSource(NCR_Instance inst, RPT_SourceReport *report)
{
report->poll = get_transmit_poll(inst);