From 316d50d6f1a258cdbdcf9a733d86e4cdcb174834 Mon Sep 17 00:00:00 2001 From: Miroslav Lichvar Date: Tue, 19 Jul 2016 15:57:16 +0200 Subject: [PATCH] sources: optimize SRC_ReportSource() a bit Remove unnecessary memset() call and use the default case of the switch to report the unreachable state. --- sources.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/sources.c b/sources.c index 79f72cf..e5627ed 100644 --- a/sources.c +++ b/sources.c @@ -1294,7 +1294,6 @@ SRC_ReportSource(int index, RPT_SourceReport *report, struct timeval *now) } else { src = sources[index]; - memset(&report->ip_addr, 0, sizeof (report->ip_addr)); if (src->ip_addr) report->ip_addr = *src->ip_addr; else { @@ -1304,14 +1303,6 @@ SRC_ReportSource(int index, RPT_SourceReport *report, struct timeval *now) } switch (src->status) { - case SRC_UNSELECTABLE: - case SRC_BAD_STATS: - case SRC_BAD_DISTANCE: - case SRC_STALE: - case SRC_ORPHAN: - case SRC_WAITS_STATS: - report->state = RPT_UNREACH; - break; case SRC_FALSETICKER: report->state = RPT_FALSETICKER; break; @@ -1331,9 +1322,8 @@ SRC_ReportSource(int index, RPT_SourceReport *report, struct timeval *now) case SRC_SELECTED: report->state = RPT_SYNC; break; - case SRC_OK: default: - assert(0); + report->state = RPT_UNREACH; break; }