From 9e8541e3c4c89bfb7a60b404f646fab57c69ce59 Mon Sep 17 00:00:00 2001 From: Miroslav Lichvar Date: Wed, 27 Aug 2025 12:22:48 +0200 Subject: [PATCH] sys_linux: improve error message for failed PHC open If the specified PHC device cannot be opened directly, an attempt is made to open it as a network interface. When that fails, the error "Could not open PHC of iface" is misleading the user that it was handled only as an interface. Change the message to "Could not open PHC (of)" to better cover both possibilities. Also remove the errno as it's not set in all code paths. --- sys_linux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys_linux.c b/sys_linux.c index 53c49a8..ca5540f 100644 --- a/sys_linux.c +++ b/sys_linux.c @@ -944,8 +944,7 @@ SYS_Linux_OpenPHC(const char *device, int flags) if (phc_fd < 0) { phc_fd = open_phc_by_iface_name(device, flags); if (phc_fd < 0) { - LOG(LOGS_ERR, "Could not open PHC of iface %s : %s", - device, strerror(errno)); + LOG(LOGS_ERR, "Could not open PHC (of) %s", device); return -1; } phc_fd = verify_fd_is_phc(phc_fd);