DWS/chrony
1
0
Fork 0
mirror of https://gitlab.com/chrony/chrony.git synced 2025-12-06 09:35:06 -05:00
Code Issues Packages Projects Releases Wiki Activity

getdate+nts+rtc: avoid some coverity false positives

Browse Source 
Modify the code to avoid making the following calls incorrectly reported
as important findings by the coverity static analyzer:

- memset() of size 0 at the end of an array
- mktime() on a struct tm that has uninitialized tm_yday
This commit is contained in:
Miroslav Lichvar
2025-05-21 08:43:12 +02:00
parent 545bd59563
commit bda2ff77e8
3 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
nts_ke_server.c
View File

@@ -536,7 +536,8 @@ generate_key(int index)
BRIEF_ASSERT(key_length <= sizeof (key->key));
UTI_GetRandomBytesUrandom(key->key, key_length);
memset(key->key + key_length, 0, sizeof (key->key) - key_length);
if (key_length < sizeof (key->key))
memset(key->key + key_length, 0, sizeof (key->key) - key_length);
UTI_GetRandomBytes(&key->id, sizeof (key->id));
/* Encode the index in the lowest bits of the ID */