From c8a9ca4cf011a160cfc82b8890134e7535abdf8c Mon Sep 17 00:00:00 2001 From: Miroslav Lichvar Date: Mon, 3 Nov 2025 12:51:00 +0100 Subject: [PATCH] sources: don't save SST_GetSelectionData() status There is no need to save the SST_GetSelectionData() "select_ok" status as the source is immediately marked as SRC_BAD_STATS if it is not ok. Nothing else is using this information. --- sources.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/sources.c b/sources.c index c840e1b..7f6002e 100644 --- a/sources.c +++ b/sources.c @@ -54,7 +54,6 @@ static int initialised = 0; /* ================================================== */ /* Structure used to hold info for selecting between sources */ struct SelectInfo { - int select_ok; double std_dev; double root_distance; double lo_limit; @@ -1010,12 +1009,10 @@ SRC_SelectSource(SRC_Instance updated_inst) n_unreach_sources++; si = &sources[i]->sel_info; - si->select_ok = SST_GetSelectionData(sources[i]->stats, &now, - &si->lo_limit, &si->hi_limit, &si->root_distance, - &si->std_dev, &first_sample_ago, - &si->last_sample_ago); - if (!si->select_ok) { + if (!SST_GetSelectionData(sources[i]->stats, &now, &si->lo_limit, &si->hi_limit, + &si->root_distance, &si->std_dev, &first_sample_ago, + &si->last_sample_ago)) { ++n_badstats_sources; mark_source(sources[i], SRC_BAD_STATS); if (max_badstat_reach < sources[i]->reachability)