move auth and favicon form main to handlers, linting

cmd/main.go

@@ -6,7 +6,6 @@ import (
 	"html/template"
 	"log"
 	"os"
-	"strings"
 
 	"ladder/handlers"
 	"ladder/internal/cli"
@@ -14,14 +13,9 @@ import (
 
 	"github.com/akamensky/argparse"
 	"github.com/gofiber/fiber/v2"
-	"github.com/gofiber/fiber/v2/middleware/basicauth"
-	"github.com/gofiber/fiber/v2/middleware/favicon"
 	"github.com/gofiber/template/html/v2"
 )
 
-//go:embed favicon.ico
-var faviconData string
-
 //go:embed styles.css
 var cssData embed.FS
 
@@ -151,23 +145,8 @@ func main() {
 		},
 	)
 
-	// TODO: move to cmd/auth.go
-	userpass := os.Getenv("USERPASS")
-	if userpass != "" {
-		userpass := strings.Split(userpass, ":")
-
-		app.Use(basicauth.New(basicauth.Config{
-			Users: map[string]string{
-				userpass[0]: userpass[1],
-			},
-		}))
-	}
-
-	// TODO: move to handlers/favicon.go
-	app.Use(favicon.New(favicon.Config{
-		Data: []byte(faviconData),
-		URL:  "/favicon.ico",
-	}))
+	app.Use(handlers.Auth())
+	app.Use(handlers.Favicon())
 
 	if os.Getenv("NOLOGS") != "true" {
 		app.Use(func(c *fiber.Ctx) error {

handlers/auth.go

@@ -0,0 +1,25 @@
+package handlers
+
+import (
+	"os"
+	"strings"
+
+	"github.com/gofiber/fiber/v2"
+	"github.com/gofiber/fiber/v2/middleware/basicauth"
+)
+
+func Auth() fiber.Handler {
+	userpass := os.Getenv("USERPASS")
+	if userpass != "" {
+		userpass := strings.Split(userpass, ":")
+		return basicauth.New(basicauth.Config{
+			Users: map[string]string{
+				userpass[0]: userpass[1],
+			},
+		})
+	}
+
+	return func(c *fiber.Ctx) error {
+		return c.Next()
+	}
+}

handlers/favicon.go

@@ -0,0 +1,18 @@
+package handlers
+
+import (
+	_ "embed"
+
+	"github.com/gofiber/fiber/v2"
+	"github.com/gofiber/fiber/v2/middleware/favicon"
+)
+
+//go:embed favicon.ico
+var faviconData string
+
+func Favicon() fiber.Handler {
+	return favicon.New(favicon.Config{
+		Data: []byte(faviconData),
+		URL:  "/favicon.ico",
+	})
+}

proxychain/requestmodifiers/modify_path_with_regex.go

@@ -2,8 +2,9 @@ package requestmodifiers
 
 import (
 	"fmt"
-	"ladder/proxychain"
 	"regexp"
+
+	"ladder/proxychain"
 )
 
 func ModifyPathWithRegex(matchRegex string, replacement string) proxychain.RequestModification {

proxychain/responsemodifiers/patch_google_analytics.go

@@ -3,8 +3,9 @@ package responsemodifiers
 import (
 	_ "embed"
 	"io"
-	"ladder/proxychain"
 	"strings"
+
+	"ladder/proxychain"
 )
 
 //go:embed patch_google_analytics.js

proxychain/responsemodifiers/patch_tracker_scripts.go

@@ -4,9 +4,10 @@ import (
 	"embed"
 	"encoding/json"
 	"io"
-	"ladder/proxychain"
 	"log"
 	"regexp"
+
+	"ladder/proxychain"
 )
 
 //go:embed vendor/ddg-tracker-surrogates/mapping.json

proxychain/ruleset/rule.go

@@ -3,6 +3,7 @@ package ruleset_v2
 import (
 	"encoding/json"
 	"fmt"
+
 	"gopkg.in/yaml.v3"
 	"ladder/proxychain"
 )
@@ -84,7 +85,6 @@ func (rule *Rule) MarshalJSON() ([]byte, error) {
 
 // implement type yaml marshaller
 func (rule *Rule) UnmarshalYAML(unmarshal func(interface{}) error) error {
-
 	type Aux struct {
 		Domains               []string `yaml:"domains"`
 		RequestModifications  []_rqm   `yaml:"requestmodifications"`
@@ -122,7 +122,6 @@ func (rule *Rule) UnmarshalYAML(unmarshal func(interface{}) error) error {
 }
 
 func (rule *Rule) MarshalYAML() (interface{}, error) {
-
 	type Aux struct {
 		Domains               []string `yaml:"domains"`
 		RequestModifications  []_rqm   `yaml:"requestmodifications"`

proxychain/ruleset/rule_reqmod_types.gen.go

@@ -1,5 +1,5 @@
-
 package ruleset_v2
+
 // DO NOT EDIT THIS FILE. It is automatically generated by ladder/proxychain/codegen/codegen.go
 // The purpose of this is serialization of rulesets from JSON or YAML into functional options suitable
 // for use in proxychains.
@@ -179,5 +179,4 @@ func init() {
 	rqmModMap["SpoofXForwardedFor"] = func(params ...string) proxychain.RequestModification {
 		return rx.SpoofXForwardedFor(params[0])
 	}
-
 }

proxychain/ruleset/rule_resmod_types.gen.go

@@ -1,5 +1,5 @@
-
 package ruleset_v2
+
 // DO NOT EDIT THIS FILE. It is automatically generated by ladder/proxychain/codegen/codegen.go
 // The purpose of this is serialization of rulesets from JSON or YAML into functional options suitable
 // for use in proxychains.
@@ -95,5 +95,4 @@ func init() {
 	rsmModMap["RewriteHTMLResourceURLs"] = func(_ ...string) proxychain.ResponseModification {
 		return tx.RewriteHTMLResourceURLs()
 	}
-
 }

proxychain/ruleset/rule_test.go

@@ -3,8 +3,9 @@ package ruleset_v2
 import (
 	"encoding/json"
 	"fmt"
-	"gopkg.in/yaml.v3"
 	"testing"
+
+	"gopkg.in/yaml.v3"
 )
 
 // unmarshalRule is a helper function to unmarshal a Rule from a JSON string.