From 30f3c3a95fb1da8ee59eb462405ea36f27900b99 Mon Sep 17 00:00:00 2001
From: lawson89 <>
Date: Sun, 17 Aug 2014 10:26:15 -0400
Subject: [PATCH] clean up logging get link pointer showing up correctly on
 submenu items (href was left off)

---
 .../owasp/webgoat/service/HintService_1.java  | 56 -------------------
 webapp/WEB-INF/pages/main_new.jsp             |  4 +-
 webapp/js/goat.js                             |  2 +-
 3 files changed, 3 insertions(+), 59 deletions(-)
 delete mode 100644 java/org/owasp/webgoat/service/HintService_1.java

diff --git a/java/org/owasp/webgoat/service/HintService_1.java b/java/org/owasp/webgoat/service/HintService_1.java
deleted file mode 100644
index 5cbb48679..000000000
--- a/java/org/owasp/webgoat/service/HintService_1.java
+++ /dev/null
@@ -1,56 +0,0 @@
-/*
- * To change this license header, choose License Headers in Project Properties.
- * To change this template file, choose Tools | Templates
- * and open the template in the editor.
- */
-package org.owasp.webgoat.service;
-
-import java.util.ArrayList;
-import java.util.List;
-import javax.servlet.http.HttpSession;
-import org.owasp.webgoat.lessons.AbstractLesson;
-import org.owasp.webgoat.lessons.model.Hint;
-import org.owasp.webgoat.session.WebSession;
-import org.springframework.stereotype.Controller;
-import org.springframework.web.bind.annotation.RequestMapping;
-import org.springframework.web.bind.annotation.ResponseBody;
-
-/**
- *
- * @author rlawson
- */
-@Controller
-public class HintService extends BaseService {
-
-    /**
-     * Returns hints for current lesson
-     *
-     * @param session
-     * @return
-     */
-    @RequestMapping(value = "/hint.mvc", produces = "application/json")
-    public @ResponseBody
-    List<Hint> showHint(HttpSession session) {
-        List<Hint> listHints = new ArrayList<Hint>();
-        WebSession ws = getWebSesion(session);
-        AbstractLesson l = ws.getCurrentLesson();
-        if (l == null) {
-            return listHints;
-        }
-        List<String> hints;
-        hints = l.getHintsPublic(ws);
-        if (hints == null) {
-            return listHints;
-        }
-        int idx = 0;
-        for (String h : hints) {
-            Hint hint = new Hint();
-            hint.setHint(h);
-            hint.setLesson(l.getName());
-            hint.setNumber(idx);
-            listHints.add(hint);
-            idx++;
-        }
-        return listHints;
-    }
-}
diff --git a/webapp/WEB-INF/pages/main_new.jsp b/webapp/WEB-INF/pages/main_new.jsp
index 0bbb87a8d..d899ac5d4 100644
--- a/webapp/WEB-INF/pages/main_new.jsp
+++ b/webapp/WEB-INF/pages/main_new.jsp
@@ -67,9 +67,9 @@
                     <li class="sub-menu" ng-repeat="item in menuTopics">
                     <!-- TODO: implement conditional rendering -->
                             <a ng-click="expanded = !expanded" href=""><i class="fa {{item.class}}"></i><span>{{item.name}}</span></a>
-                            <ul class="slideDown" ng-show="expanded" style="display:block;">
+                            <ul class="slideDown" ng-show="expanded">
                                     <li ng-repeat="child in item.children">
-                                            <a ng-click="renderLesson(child.link)" title="link to {{child.name}}">{{child.name}}</a>
+                                            <a ng-click="renderLesson(child.link)" title="link to {{child.name}}" href="">{{child.name}}</a>
                                     </li>
                             </ul>
                     </li>
diff --git a/webapp/js/goat.js b/webapp/js/goat.js
index bdd5a0d86..1336734a0 100644
--- a/webapp/js/goat.js
+++ b/webapp/js/goat.js
@@ -41,7 +41,7 @@ goat.controller('goatMenu', function($scope, $http) {
 goat.addMenuClasses = function(arr) {
     for (var i = 0; i < arr.length; i++) {
         var menuItem = arr[i];
-        console.log(menuItem);
+        //console.log(menuItem);
         if (arr[i].type && arr[i].type === 'CATEGORY') {
             arr[i].class = 'fa-angle-right pull-right';
         }