From 7c65441c8e7c0933c032856568250bffb493542d Mon Sep 17 00:00:00 2001
From: Jason White <jason.white@owasp.org>
Date: Thu, 18 Feb 2016 19:44:12 -0500
Subject: [PATCH 1/2] #180, better management of show* buttons

---
 .../main/webapp/WEB-INF/pages/main_new.jsp    |  5 +++
 .../js/goatApp/view/HelpControlsView.js       | 41 ++++++++++---------
 2 files changed, 26 insertions(+), 20 deletions(-)

diff --git a/webgoat-container/src/main/webapp/WEB-INF/pages/main_new.jsp b/webgoat-container/src/main/webapp/WEB-INF/pages/main_new.jsp
index 8946fa162..57a9d54e6 100644
--- a/webgoat-container/src/main/webapp/WEB-INF/pages/main_new.jsp
+++ b/webgoat-container/src/main/webapp/WEB-INF/pages/main_new.jsp
@@ -102,6 +102,11 @@
                         <div class="col-md-8">
                             <div class="col-md-12" align="left">
                                 <div class="panel" id="help-controls">
+                                    <button class="btn btn-primary btn-xs help-button" id="show-source-button">Show Source</button>
+                                    <button class="btn btn-primary btn-xs help-button" id="show-solution-button">Show Solution</button>
+                                    <button class="btn btn-primary btn-xs help-button" id="show-plan-button">Show Plan</button>
+                                    <button class="btn btn-primary btn-xs help-button" id="show-hints-button">Show Hints</button>
+                                    <button class="btn btn-xs help-button" id="show-hints-button">Restart Lesson</button>
                                 </div>
                                 <div class="lesson-hint" id="lesson-hint-container">
                                     <h4>Hints</h4>
diff --git a/webgoat-container/src/main/webapp/js/goatApp/view/HelpControlsView.js b/webgoat-container/src/main/webapp/js/goatApp/view/HelpControlsView.js
index 905ddbaa8..e9c354ce3 100644
--- a/webgoat-container/src/main/webapp/js/goatApp/view/HelpControlsView.js
+++ b/webgoat-container/src/main/webapp/js/goatApp/view/HelpControlsView.js
@@ -4,14 +4,14 @@ define(['jquery',
 function($,_,Backbone) {
 	return Backbone.View.extend({
 		el:'#help-controls', //Check this
-		helpButtons: {
-			//TODO: move this into a template
-			showSource:$('<button>',{id:'show-source-button','class':'btn btn-primary btn-xs help-button',type:'button',text:'Java Source'}),
-			showSolution:$('<button>',{id:'show-solution-button','class':'btn btn-primary btn-xs help-button',type:'button',text:'Solution'}),
-			showPlan:$('<button>',{id:'show-plan-button','class':'btn btn-primary btn-xs help-button',type:'button',text:'Lesson Plan'}),
-			showHints:$('<button>',{id:'show-hints-button','class':'btn btn-primary btn-xs help-button',type:'button',text:'Hints'}),
-			restartLesson:$('<button>',{id:'restart-lesson-button','class':'btn btn-xs help-button',type:'button',text:'Restart Lesson'})
-		},
+//		helpButtons: {
+//			//TODO: move this into a template
+//			showSource:,
+//			showSolution:,
+//			showPlan:,
+//			showHints:,
+//			restartLesson:
+//		},
 		initialize: function (options) {
 			if (!options) {
 				return;
@@ -22,27 +22,28 @@ function($,_,Backbone) {
 			this.hasHints = options.hasHints;
 		},
 		render:function(title) {
-			this.$el.html();
-			
+			//this.$el.html();
+			// if still showing, hide
+			$('#show-source-button').hide();
+			$('#show-solution-button').hide();
+			$('#show-plan-button').hide();
+			$('#show-hints-button').hide();
+
 			if (this.hasSource) {
-				this.helpButtons.showSource.unbind().on('click',_.bind(this.showSource,this));
-				this.$el.append(this.helpButtons.showSource);
+				this.$el.find('#show-source-button').unbind().on('click',_.bind(this.showSource,this)).show();
 			}
 			if (this.hasSolution) {
-				this.helpButtons.showSolution.unbind().on('click',_.bind(this.showSolution,this));
-				this.$el.append(this.helpButtons.showSolution);
+				this.$el.find('#show-solution-button').unbind().on('click',_.bind(this.showSolution,this)).show();
 			}
 			if (this.hasPlan) {
-				this.helpButtons.showPlan.unbind().on('click',_.bind(this.showPlan,this));
-				this.$el.append(this.helpButtons.showPlan);
+				this.$el.find('#show-plan-button').unbind().on('click',_.bind(this.showPlan,this)).show();
 			}
 			if (this.hasHints) {
-				this.helpButtons.showHints.unbind().on('click',_.bind(this.showHints,this));
-				this.$el.append(this.helpButtons.showHints);
+				this.$el.find('#show-hints-button').unbind().on('click',_.bind(this.showHints,this)).show();
 			}
 			
-			this.helpButtons.restartLesson.unbind().on('click',_.bind(this.restartLesson,this));
-			this.$el.append(this.helpButtons.restartLesson);
+			this.$el.find('#restart-lesson-button').unbind().on('click',_.bind(this.restartLesson,this)).show();
+			//this.$el.append(this.helpButtons.restartLesson);
 		},
 
 		showSource: function() {

From 575c9406557734f89fd6489de0074e5f9294da6c Mon Sep 17 00:00:00 2001
From: Jason White <jason.white@owasp.org>
Date: Thu, 18 Feb 2016 21:26:32 -0500
Subject: [PATCH 2/2] #180, clean up

---
 .../main/webapp/js/goatApp/view/HelpControlsView.js    | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/webgoat-container/src/main/webapp/js/goatApp/view/HelpControlsView.js b/webgoat-container/src/main/webapp/js/goatApp/view/HelpControlsView.js
index e9c354ce3..2a3e6da6b 100644
--- a/webgoat-container/src/main/webapp/js/goatApp/view/HelpControlsView.js
+++ b/webgoat-container/src/main/webapp/js/goatApp/view/HelpControlsView.js
@@ -4,14 +4,7 @@ define(['jquery',
 function($,_,Backbone) {
 	return Backbone.View.extend({
 		el:'#help-controls', //Check this
-//		helpButtons: {
-//			//TODO: move this into a template
-//			showSource:,
-//			showSolution:,
-//			showPlan:,
-//			showHints:,
-//			restartLesson:
-//		},
+
 		initialize: function (options) {
 			if (!options) {
 				return;
@@ -21,6 +14,7 @@ function($,_,Backbone) {
 			this.hasSource = options.hasSource;
 			this.hasHints = options.hasHints;
 		},
+		    
 		render:function(title) {
 			//this.$el.html();
 			// if still showing, hide