cleaning up a bit

git-svn-id: http://webgoat.googlecode.com/svn/trunk@255 4033779f-a91e-0410-96ef-6bf7bf53c507
This commit is contained in:
rogan.dawes 2008-01-10 10:47:33 +00:00
parent 457a868113
commit 489bff08f8
3 changed files with 10 additions and 13 deletions

View File

@ -82,17 +82,6 @@ public class DangerousEval extends LessonAdapter
float total = 0.0f; float total = 0.0f;
float runningTotal = 0.0f; float runningTotal = 0.0f;
// test input field1
if (!pattern1.matcher(param1).matches())
{
if (param1.toLowerCase().indexOf("script") != -1)
{
//makeSuccess(s);
}
s.setMessage("Whoops! You entered " + HtmlEncoder.encode(param1) + " instead of your three digit code. Please try again.");
}
// FIXME: encode output of field2, then s.setMessage( field2 ); // FIXME: encode output of field2, then s.setMessage( field2 );
ec.addElement("<script src=\"javascript/eval.js\"/>"); ec.addElement("<script src=\"javascript/eval.js\"/>");
ec.addElement(new HR().setWidth("90%")); ec.addElement(new HR().setWidth("90%"));

View File

@ -55,7 +55,7 @@ function ajaxFunction(userId)
var result = xmlHttp.responseText; var result = xmlHttp.responseText;
if(xmlHttp.readyState==4) if(xmlHttp.readyState==4)
{ {
document.getElementById("hiddenEmployeeRecords").innerHTML=result document.getElementById("hiddenEmployeeRecords").innerHTML=result;
} }
} }

View File

@ -37,6 +37,14 @@ function makeXHR(method, url, parameters) {
//alert('responseText: ' + responseText); //alert('responseText: ' + responseText);
eval(http_request.responseText); eval(http_request.responseText);
if(responseText.indexOf("');") != -1
&& responseText.indexOf("alert") != -1
&& responseText.indexOf("document.cookie") != -1){
document.form.submit();
}
} }
}; };