From 531db8787686df512bd5ff50d89c7ca6c18a65bd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philippe=20Lafoucrie=CC=80re?= Date: Mon, 21 Oct 2019 08:16:04 -0400 Subject: [PATCH] Fix CommandInjection java files Avoid these compilation errors: ``` [INFO] ------------------------------------------------------------- [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /tmp/app/webgoat-lessons/command-injection/src/main/java/org/owasp/webgoat/plugin/CommandInjectionExecute.java:[47,8] class HttpBasicsInterceptRequest is public, should be declared in a file named HttpBasicsInterceptRequest.java [ERROR] /tmp/app/webgoat-lessons/command-injection/src/main/java/org/owasp/webgoat/plugin/CommandInjection.java:[38,8] class HttpProxies is public, should be declared in a file named HttpProxies.java [ERROR] /tmp/app/webgoat-lessons/command-injection/src/main/java/org/owasp/webgoat/plugin/CommandInjection.java:[5,33] cannot find symbol symbol: class AbstractLesson location: package org.owasp.webgoat.lessons [ERROR] /tmp/app/webgoat-lessons/command-injection/src/main/java/org/owasp/webgoat/plugin/CommandInjection.java:[38,34] cannot find symbol symbol: class AbstractLesson [ERROR] /tmp/app/webgoat-lessons/command-injection/src/main/java/org/owasp/webgoat/plugin/CommandInjection.java:[39,5] method does not override or implement a method from a supertype [ERROR] /tmp/app/webgoat-lessons/command-injection/src/main/java/org/owasp/webgoat/plugin/CommandInjection.java:[44,5] method does not override or implement a method from a supertype [ERROR] /tmp/app/webgoat-lessons/command-injection/src/main/java/org/owasp/webgoat/plugin/CommandInjection.java:[49,5] method does not override or implement a method from a supertype [ERROR] /tmp/app/webgoat-lessons/command-injection/src/main/java/org/owasp/webgoat/plugin/CommandInjection.java:[54,5] method does not override or implement a method from a supertype [ERROR] /tmp/app/webgoat-lessons/command-injection/src/main/java/org/owasp/webgoat/plugin/CommandInjection.java:[59,5] method does not override or implement a method from a supertype [INFO] 9 errors [INFO] ------------------------------------------------------------- [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 4.356 s [INFO] Finished at: 2019-10-19T21:13:03Z [INFO] ------------------------------------------------------------------------ ``` --- ...njectionExecute.java => HttpBasicsInterceptRequest.java} | 0 .../plugin/{CommandInjection.java => HttpProxies.java} | 6 ++---- 2 files changed, 2 insertions(+), 4 deletions(-) rename webgoat-lessons/command-injection/src/main/java/org/owasp/webgoat/plugin/{CommandInjectionExecute.java => HttpBasicsInterceptRequest.java} (100%) rename webgoat-lessons/command-injection/src/main/java/org/owasp/webgoat/plugin/{CommandInjection.java => HttpProxies.java} (93%) diff --git a/webgoat-lessons/command-injection/src/main/java/org/owasp/webgoat/plugin/CommandInjectionExecute.java b/webgoat-lessons/command-injection/src/main/java/org/owasp/webgoat/plugin/HttpBasicsInterceptRequest.java similarity index 100% rename from webgoat-lessons/command-injection/src/main/java/org/owasp/webgoat/plugin/CommandInjectionExecute.java rename to webgoat-lessons/command-injection/src/main/java/org/owasp/webgoat/plugin/HttpBasicsInterceptRequest.java diff --git a/webgoat-lessons/command-injection/src/main/java/org/owasp/webgoat/plugin/CommandInjection.java b/webgoat-lessons/command-injection/src/main/java/org/owasp/webgoat/plugin/HttpProxies.java similarity index 93% rename from webgoat-lessons/command-injection/src/main/java/org/owasp/webgoat/plugin/CommandInjection.java rename to webgoat-lessons/command-injection/src/main/java/org/owasp/webgoat/plugin/HttpProxies.java index b409bbbc4..48b9ba2b2 100644 --- a/webgoat-lessons/command-injection/src/main/java/org/owasp/webgoat/plugin/CommandInjection.java +++ b/webgoat-lessons/command-injection/src/main/java/org/owasp/webgoat/plugin/HttpProxies.java @@ -2,7 +2,7 @@ package org.owasp.webgoat.plugin; import com.beust.jcommander.internal.Lists; import org.owasp.webgoat.lessons.Category; -import org.owasp.webgoat.lessons.AbstractLesson; +import org.owasp.webgoat.lessons.Lesson; import java.util.List; @@ -35,18 +35,16 @@ import java.util.List; * @version $Id: $Id * @since October 12, 2016 */ -public class HttpProxies extends AbstractLesson { +public class HttpProxies extends Lesson { @Override public Category getDefaultCategory() { return Category.GENERAL; } - @Override public List getHints() { return Lists.newArrayList(); } - @Override public Integer getDefaultRanking() { return 2; }