From 88a730f225046e5f90957bd8414a6848f735066c Mon Sep 17 00:00:00 2001
From: mayhew64 <mayhew64@4033779f-a91e-0410-96ef-6bf7bf53c507>
Date: Tue, 3 Feb 2009 17:55:27 +0000
Subject: [PATCH] Removed errors introduced in previous checkin.  String and
 integer conflicts in JSP

git-svn-id: http://webgoat.googlecode.com/svn/trunk@374 4033779f-a91e-0410-96ef-6bf7bf53c507
---
 .../RoleBasedAccessControl/ViewProfile.jsp    | 38 +++++++++----------
 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/webgoat/main/project/WebContent/lessons/RoleBasedAccessControl/ViewProfile.jsp b/webgoat/main/project/WebContent/lessons/RoleBasedAccessControl/ViewProfile.jsp
index 6b5ecab0d..896eec8f3 100644
--- a/webgoat/main/project/WebContent/lessons/RoleBasedAccessControl/ViewProfile.jsp
+++ b/webgoat/main/project/WebContent/lessons/RoleBasedAccessControl/ViewProfile.jsp
@@ -2,9 +2,9 @@
 	import="org.owasp.webgoat.session.*, org.owasp.webgoat.lessons.RoleBasedAccessControl.RoleBasedAccessControl" 
 	errorPage="" %>
 <%
-	WebSession webSession = ((WebSession)session.getAttribute("websession"));
 	Employee employee = (Employee) session.getAttribute("RoleBasedAccessControl." + RoleBasedAccessControl.EMPLOYEE_ATTRIBUTE_KEY);
-	//int myUserId = webSession.getUserIdInLesson();
+	WebSession webSession = ((WebSession)session.getAttribute("websession"));
+//	int myUserId = getIntSessionAttribute(webSession, "RoleBasedAccessControl." + RoleBasedAccessControl.USER_ID);
 %>
 		<div class="lesson_title_box"><strong>Welcome Back </strong><span class="lesson_text_db"><%=webSession.getUserNameInLesson()%></span> - View Profile Page</div>
 		<div class="lesson_text">
@@ -13,71 +13,71 @@
 						First Name:
 					</TD>
 					<TD>
-						<span class="lesson_text_db"><%=(employee == null ? "unknown" : employee.getFirstName())%></span>
+						<span class="lesson_text_db"><%=employee.getFirstName()%></span>
 					</TD>
 					<TD>				
 						Last Name:
 					</TD>
 					<TD>
-					 	<span class="lesson_text_db"><%=(employee == null ? "unknown" : employee.getLastName())%></span>
+					 	<span class="lesson_text_db"><%=employee.getLastName()%></span>
 					</TD>
 				</TR>
 				<TR><TD>				
 						Street: 
 					</TD>
 					<TD>
-						<span class="lesson_text_db"><%=(employee == null ? "unknown" : employee.getAddress1())%></span>
+						<span class="lesson_text_db"><%=employee.getAddress1()%></span>
 					</TD>
 					<TD>				
 						City/State: 
 					<TD>
-						<span class="lesson_text_db"><%=(employee == null ? "unknown" : employee.getAddress2())%></span>
+						<span class="lesson_text_db"><%=employee.getAddress2()%></span>
 					</TD>
 				</TR>
 				<TR><TD>
 						Phone: 
 					</TD>
 					<TD>
-						<span class="lesson_text_db"><%=(employee == null ? "unknown" : employee.getPhoneNumber())%></span>
+						<span class="lesson_text_db"><%=employee.getPhoneNumber()%></span>
 					</TD>
 					<TD>				
 						Start Date: 
 					</TD>
 					<TD>
-						<span class="lesson_text_db"><%=(employee == null ? "unknown" : employee.getStartDate())%></span>
+						<span class="lesson_text_db"><%=employee.getStartDate()%></span>
 					</TD>
 				</TR>
 				<TR><TD>
 			    		SSN: 
 			    	</TD>
 			    	<TD>
-			    		<span class="lesson_text_db"><%=(employee == null ? "unknown" : employee.getSsn())%></span>
+			    		<span class="lesson_text_db"><%=employee.getSsn()%></span>
 					</TD>
 					<TD>				
 						Salary: 
 					</TD>
 					<TD>
-						<span class="lesson_text_db"><%=(employee == null ? "unknown" : employee.getSalary())%></span>
+						<span class="lesson_text_db"><%=employee.getSalary()%></span>
 					</TD>
 				</TR>
 				<TR><TD>
 						Credit Card: 
 					</TD>
 					<TD>
-						<span class="lesson_text_db"><%=(employee == null ? "unknown" : employee.getCcn())%></span>
+						<span class="lesson_text_db"><%=employee.getCcn()%></span>
 					</TD>
 					<TD>				
 						Credit Card Limit: 
 					</TD>
 					<TD>
-						<span class="lesson_text_db"><%=(employee == null ? "unknown" : employee.getCcnLimit())%></span>
+						<span class="lesson_text_db"><%=employee.getCcnLimit()%></span>
 					</TD>
 				</TR>
 				<TR><TD>
 						Comments: 
 					</TD>
 					<TD colspan="3">
-						<span class="lesson_text_db"><%=(employee == null ? "unknown" : employee.getPersonalDescription())%></span>
+						<span class="lesson_text_db"><%=employee.getPersonalDescription()%></span>
 					</TD>
 				</TR>				
 				<TR>
@@ -88,11 +88,11 @@
 						Disc. Dates: 
 					</TD>
 					<TD>
-						<span class="lesson_text_db"><%=(employee == null ? "unknown" : employee.getDisciplinaryActionDate())%></span>
+						<span class="lesson_text_db"><%=employee.getDisciplinaryActionDate()%></span>
 					</TD>
 				<TR>
 					<TD colspan="4">
-						<span class="lesson_text_db"><%=(employee == null ? "unknown" : employee.getDisciplinaryActionNotes())%></span>
+						<span class="lesson_text_db"><%=employee.getDisciplinaryActionNotes()%></span>
 					</TD>
 				</TR>
 				<TR>
@@ -100,7 +100,7 @@
 						Manager: 
 					</TD>
 					<TD>
-						<span class="lesson_text_db"><%=(employee == null ? "unknown" : employee.getManager())%></span>
+						<span class="lesson_text_db"><%=employee.getManager()%></span>
 					</TD>	
 				</TR>
 				</Table>
@@ -114,7 +114,7 @@
 					 {
 					 %>
 						<form method="POST" action="<%=webSession.getCurrentLesson().getFormAction()%>">
-							<input type="hidden" name="<%=RoleBasedAccessControl.EMPLOYEE_ID%>" value="<%=(employee == null ? "unknown" : employee.getId())%>">
+							<input type="hidden" name="<%=RoleBasedAccessControl.EMPLOYEE_ID%>" value="<%=employee.getId()%>">
 							<input type="submit" name="action" value="<%=RoleBasedAccessControl.LISTSTAFF_ACTION%>"/>
 						</form>
 					 <%
@@ -126,7 +126,7 @@
 					 {
 					 %>
 						<form method="POST" action="<%=webSession.getCurrentLesson().getFormAction()%>">
-							<input type="hidden" name="<%=RoleBasedAccessControl.EMPLOYEE_ID%>" value="<%=(employee == null ? "unknown" : employee.getId())%>">
+							<input type="hidden" name="<%=RoleBasedAccessControl.EMPLOYEE_ID%>" value="<%=employee.getId()%>">
 							<input type="submit" name="action" value="<%=RoleBasedAccessControl.EDITPROFILE_ACTION%>"/>
 						</form>
 					<%
@@ -139,7 +139,7 @@
 					{
 					%>
 						<form method="POST" action="<%=webSession.getCurrentLesson().getFormAction()%>">
-							<input type="hidden" name="<%=RoleBasedAccessControl.EMPLOYEE_ID%>" value="<%=(employee == null ? "unknown" : employee.getId())%>">
+							<input type="hidden" name="<%=RoleBasedAccessControl.EMPLOYEE_ID%>" value="<%=employee.getId()%>">
 							<input type="submit" name="action" value="<%=RoleBasedAccessControl.DELETEPROFILE_ACTION%>"/>
 						</form>
 					<%