From 935871c39ab9d043fde9568db9fabe1dc66e3ede Mon Sep 17 00:00:00 2001 From: Nanne Baars Date: Sun, 28 Mar 2021 17:41:19 +0200 Subject: [PATCH] Add some debugging information to know which test cases might have failed --- .../src/test/java/org/owasp/webgoat/IntegrationTest.java | 3 +++ .../xxe/src/main/java/org/owasp/webgoat/xxe/Comment.java | 2 ++ .../xxe/src/main/java/org/owasp/webgoat/xxe/SimpleXXE.java | 1 + 3 files changed, 6 insertions(+) diff --git a/webgoat-integration-tests/src/test/java/org/owasp/webgoat/IntegrationTest.java b/webgoat-integration-tests/src/test/java/org/owasp/webgoat/IntegrationTest.java index 4d8501a9a..8bc9e7db9 100644 --- a/webgoat-integration-tests/src/test/java/org/owasp/webgoat/IntegrationTest.java +++ b/webgoat-integration-tests/src/test/java/org/owasp/webgoat/IntegrationTest.java @@ -3,6 +3,7 @@ package org.owasp.webgoat; import io.restassured.RestAssured; import io.restassured.http.ContentType; import lombok.Getter; +import lombok.extern.slf4j.Slf4j; import org.hamcrest.CoreMatchers; import org.hamcrest.MatcherAssert; import org.junit.jupiter.api.AfterEach; @@ -18,6 +19,7 @@ import java.util.UUID; import static io.restassured.RestAssured.given; +@Slf4j public abstract class IntegrationTest { protected static int WG_PORT = 8080; @@ -262,6 +264,7 @@ public abstract class IntegrationTest { } public void checkAssignmentWithGet(String url, Map params, boolean expectedResult) { + log.info("Checking assignment for: {}", url); MatcherAssert.assertThat( RestAssured.given() .when() diff --git a/webgoat-lessons/xxe/src/main/java/org/owasp/webgoat/xxe/Comment.java b/webgoat-lessons/xxe/src/main/java/org/owasp/webgoat/xxe/Comment.java index 7471b2a10..da8993bf5 100644 --- a/webgoat-lessons/xxe/src/main/java/org/owasp/webgoat/xxe/Comment.java +++ b/webgoat-lessons/xxe/src/main/java/org/owasp/webgoat/xxe/Comment.java @@ -26,6 +26,7 @@ import lombok.AllArgsConstructor; import lombok.Getter; import lombok.NoArgsConstructor; import lombok.Setter; +import lombok.ToString; import javax.xml.bind.annotation.XmlRootElement; @@ -38,6 +39,7 @@ import javax.xml.bind.annotation.XmlRootElement; @AllArgsConstructor @NoArgsConstructor @XmlRootElement +@ToString public class Comment { private String user; private String dateTime; diff --git a/webgoat-lessons/xxe/src/main/java/org/owasp/webgoat/xxe/SimpleXXE.java b/webgoat-lessons/xxe/src/main/java/org/owasp/webgoat/xxe/SimpleXXE.java index 65825201f..d4cfbe3c3 100644 --- a/webgoat-lessons/xxe/src/main/java/org/owasp/webgoat/xxe/SimpleXXE.java +++ b/webgoat-lessons/xxe/src/main/java/org/owasp/webgoat/xxe/SimpleXXE.java @@ -76,6 +76,7 @@ public class SimpleXXE extends AssignmentEndpoint { secure = true; } Comment comment = comments.parseXml(commentStr, secure); + System.err.println("Comment " + comment); comments.addComment(comment, false); if (checkSolution(comment)) { return success(this).build();