From 96412da04eb390fe396f1ac17698fd0e6e1769df Mon Sep 17 00:00:00 2001 From: Nanne Baars Date: Sat, 18 Apr 2020 21:00:45 +0200 Subject: [PATCH] Remove unused imports and parameters --- .../java/org/owasp/webgoat/http_basics/HttpBasicsQuiz.java | 2 +- .../sql_injection/mitigation/SqlOnlyInputValidation.java | 1 - .../sql_injection/introduction/SqlInjectionLesson6aTest.java | 4 ---- 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/webgoat-lessons/http-basics/src/main/java/org/owasp/webgoat/http_basics/HttpBasicsQuiz.java b/webgoat-lessons/http-basics/src/main/java/org/owasp/webgoat/http_basics/HttpBasicsQuiz.java index 3716222de..913fed785 100644 --- a/webgoat-lessons/http-basics/src/main/java/org/owasp/webgoat/http_basics/HttpBasicsQuiz.java +++ b/webgoat-lessons/http-basics/src/main/java/org/owasp/webgoat/http_basics/HttpBasicsQuiz.java @@ -38,7 +38,7 @@ public class HttpBasicsQuiz extends AssignmentEndpoint { @PostMapping("/HttpBasics/attack2") @ResponseBody - public AttackResult completed(@RequestParam String answer, @RequestParam String magic_answer, @RequestParam String magic_num, HttpServletRequest request) throws IOException { + public AttackResult completed(@RequestParam String answer, @RequestParam String magic_answer, @RequestParam String magic_num) throws IOException { if ("POST".equals(answer.toUpperCase()) && magic_answer.equals(magic_num)) { return success(this).build(); } else { diff --git a/webgoat-lessons/sql-injection/src/main/java/org/owasp/webgoat/sql_injection/mitigation/SqlOnlyInputValidation.java b/webgoat-lessons/sql-injection/src/main/java/org/owasp/webgoat/sql_injection/mitigation/SqlOnlyInputValidation.java index ae6327529..0bfa5baf3 100644 --- a/webgoat-lessons/sql-injection/src/main/java/org/owasp/webgoat/sql_injection/mitigation/SqlOnlyInputValidation.java +++ b/webgoat-lessons/sql-injection/src/main/java/org/owasp/webgoat/sql_injection/mitigation/SqlOnlyInputValidation.java @@ -23,7 +23,6 @@ package org.owasp.webgoat.sql_injection.mitigation; -import org.apache.commons.lang3.StringEscapeUtils; import org.owasp.webgoat.assignments.AssignmentEndpoint; import org.owasp.webgoat.assignments.AssignmentHints; import org.owasp.webgoat.assignments.AttackResult; diff --git a/webgoat-lessons/sql-injection/src/test/java/org/owasp/webgoat/sql_injection/introduction/SqlInjectionLesson6aTest.java b/webgoat-lessons/sql-injection/src/test/java/org/owasp/webgoat/sql_injection/introduction/SqlInjectionLesson6aTest.java index 9496ee068..37bc54018 100644 --- a/webgoat-lessons/sql-injection/src/test/java/org/owasp/webgoat/sql_injection/introduction/SqlInjectionLesson6aTest.java +++ b/webgoat-lessons/sql-injection/src/test/java/org/owasp/webgoat/sql_injection/introduction/SqlInjectionLesson6aTest.java @@ -22,18 +22,14 @@ package org.owasp.webgoat.sql_injection.introduction; -import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; -import org.owasp.webgoat.plugins.LessonTest; import org.owasp.webgoat.sql_injection.SqlLessonTest; import org.springframework.test.context.junit4.SpringJUnit4ClassRunner; import org.springframework.test.web.servlet.request.MockMvcRequestBuilders; -import org.springframework.test.web.servlet.setup.MockMvcBuilders; import static org.hamcrest.Matchers.containsString; import static org.hamcrest.Matchers.is; -import static org.mockito.Mockito.when; import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath; import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;