From 9ea97126b8a21ba7a5f3c8de4c8802a3091ba2c6 Mon Sep 17 00:00:00 2001 From: "rogan.dawes" Date: Wed, 18 Jul 2007 13:31:11 +0000 Subject: [PATCH] Use AbstractLesson.getLink() and getFormAction() more Rather than constructing URL's manually all the time, rather make use of existing mechanisms to create the URL, and use it consistently. git-svn-id: http://webgoat.googlecode.com/svn/trunk@184 4033779f-a91e-0410-96ef-6bf7bf53c507 --- .../owasp/webgoat/lessons/AbstractLesson.java | 4 +- .../org/owasp/webgoat/lessons/CSRF.java | 10 ++--- .../owasp/webgoat/lessons/DOMInjection.java | 4 +- .../owasp/webgoat/lessons/JSONInjection.java | 5 +-- .../webgoat/lessons/SilentTransactions.java | 5 +-- .../owasp/webgoat/lessons/XMLInjection.java | 5 +-- .../org/owasp/webgoat/session/WebSession.java | 37 +------------------ .../lessons/ConfManagement/config.jsp | 10 +++-- .../CrossSiteScripting/EditProfile.jsp | 2 +- .../lessons/CrossSiteScripting/ListStaff.jsp | 2 +- .../lessons/CrossSiteScripting/Login.jsp | 2 +- .../CrossSiteScripting/SearchStaff.jsp | 2 +- .../CrossSiteScripting/ViewProfile.jsp | 6 +-- .../DBCrossSiteScripting/EditProfile.jsp | 2 +- .../DBCrossSiteScripting/ListStaff.jsp | 2 +- .../lessons/DBCrossSiteScripting/Login.jsp | 2 +- .../DBCrossSiteScripting/SearchStaff.jsp | 2 +- .../DBCrossSiteScripting/ViewProfile.jsp | 6 +-- .../lessons/DBSQLInjection/EditProfile.jsp | 2 +- .../lessons/DBSQLInjection/ListStaff.jsp | 2 +- .../lessons/DBSQLInjection/Login.jsp | 2 +- .../lessons/DBSQLInjection/SearchStaff.jsp | 2 +- .../lessons/DBSQLInjection/ViewProfile.jsp | 6 +-- .../GoatHillsFinancial/EditProfile.jsp | 2 +- .../lessons/GoatHillsFinancial/ListStaff.jsp | 2 +- .../lessons/GoatHillsFinancial/Login.jsp | 2 +- .../GoatHillsFinancial/SearchStaff.jsp | 2 +- .../GoatHillsFinancial/ViewProfile.jsp | 6 +-- .../lessons/GoatHillsFinancial/error.jsp | 2 +- .../RoleBasedAccessControl/EditProfile.jsp | 2 +- .../RoleBasedAccessControl/ListStaff.jsp | 2 +- .../lessons/RoleBasedAccessControl/Login.jsp | 2 +- .../RoleBasedAccessControl/SearchStaff.jsp | 2 +- .../RoleBasedAccessControl/ViewProfile.jsp | 6 +-- .../lessons/RoleBasedAccessControl/error.jsp | 2 +- .../lessons/SQLInjection/EditProfile.jsp | 2 +- .../lessons/SQLInjection/ListStaff.jsp | 2 +- .../WebContent/lessons/SQLInjection/Login.jsp | 2 +- .../lessons/SQLInjection/SearchStaff.jsp | 2 +- .../lessons/SQLInjection/ViewProfile.jsp | 6 +-- webgoat/main/project/WebContent/main.jsp | 2 +- 41 files changed, 61 insertions(+), 109 deletions(-) diff --git a/ webgoat/main/project/JavaSource/org/owasp/webgoat/lessons/AbstractLesson.java b/ webgoat/main/project/JavaSource/org/owasp/webgoat/lessons/AbstractLesson.java index 531dcf367..bba7c5a28 100644 --- a/ webgoat/main/project/JavaSource/org/owasp/webgoat/lessons/AbstractLesson.java +++ b/ webgoat/main/project/JavaSource/org/owasp/webgoat/lessons/AbstractLesson.java @@ -795,9 +795,9 @@ public abstract class AbstractLesson extends Screen implements Comparable } - protected String getFormAction() + public String getFormAction() { - return "attack" + "?menu=" + getCategory().getRanking(); + return getLink(); } diff --git a/ webgoat/main/project/JavaSource/org/owasp/webgoat/lessons/CSRF.java b/ webgoat/main/project/JavaSource/org/owasp/webgoat/lessons/CSRF.java index 0bb336f23..e19cedb5e 100644 --- a/ webgoat/main/project/JavaSource/org/owasp/webgoat/lessons/CSRF.java +++ b/ webgoat/main/project/JavaSource/org/owasp/webgoat/lessons/CSRF.java @@ -186,10 +186,8 @@ public class CSRF extends LessonAdapter { for ( int i = 0; results.next(); i++ ) { - String link = "" + results.getString( TITLE_COL ) + ""; + String link = "" + results.getString( TITLE_COL ) + ""; TD td = new TD().addElement( link ); TR tr = new TR().addElement( td ); t.addElement( tr ); @@ -297,9 +295,7 @@ public class CSRF extends LessonAdapter { hints.add( "Enter some text and try to include an image in there." ); hints.add( "In order to make the picture almost invisible try to add width=\"1\" and height=\"1\"." ); hints.add( "The format of an image in html is
<img src=\"[URL]\" width=\"1\" height=\"1\" />
"); - hints.add( "Include this URL in the message
<img src='http://localhost/WebGoat/attack?"+
-			        "Screen=" + String.valueOf(getScreenId()) +
-			        "&menu=" + getDefaultCategory().getRanking().toString() +
+		hints.add( "Include this URL in the message 
<img src='" + getLink() +
 			        "&transferFunds=5000' width=\"1\" height=\"1\" />
"); return hints; diff --git a/ webgoat/main/project/JavaSource/org/owasp/webgoat/lessons/DOMInjection.java b/ webgoat/main/project/JavaSource/org/owasp/webgoat/lessons/DOMInjection.java index d8fc9261a..45faa4561 100644 --- a/ webgoat/main/project/JavaSource/org/owasp/webgoat/lessons/DOMInjection.java +++ b/ webgoat/main/project/JavaSource/org/owasp/webgoat/lessons/DOMInjection.java @@ -95,9 +95,7 @@ public class DOMInjection extends LessonAdapter String lineSep = System.getProperty("line.separator"); String script = "