From b219854f81052d86d04741997da765a7416c9813 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9=20Zubcevic?= Date: Mon, 11 Jan 2021 20:15:23 +0100 Subject: [PATCH] fix in case external site is down (#919) --- .../ssrf/src/main/java/org/owasp/webgoat/ssrf/SSRFTask2.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/webgoat-lessons/ssrf/src/main/java/org/owasp/webgoat/ssrf/SSRFTask2.java b/webgoat-lessons/ssrf/src/main/java/org/owasp/webgoat/ssrf/SSRFTask2.java index 533fd7910..389d6df81 100644 --- a/webgoat-lessons/ssrf/src/main/java/org/owasp/webgoat/ssrf/SSRFTask2.java +++ b/webgoat-lessons/ssrf/src/main/java/org/owasp/webgoat/ssrf/SSRFTask2.java @@ -51,6 +51,7 @@ public class SSRFTask2 extends AssignmentEndpoint { StringBuffer html = new StringBuffer(); if (url.matches("http://ifconfig.pro")) { + try { URL u = new URL(url); URLConnection urlConnection = u.openConnection(); BufferedReader in = new BufferedReader(new InputStreamReader(urlConnection.getInputStream())); @@ -60,6 +61,10 @@ public class SSRFTask2 extends AssignmentEndpoint { html.append(inputLine); } in.close(); + } catch (Exception e) { + //in case the external site is down, the test and lesson should still be ok + html.append("Altough the http://ifconfig.pro site is down, you still managed to solve this exercise the right way!"); + } return success(this) .feedback("ssrf.success")