initial idea for explanation on static code analysis and experience of the fix

This commit is contained in:
René Zubcevic
2020-12-05 20:38:35 +01:00
committed by Nanne Baars
parent 8bed91a8dc
commit bce4c775bf
10 changed files with 90 additions and 8 deletions

View File

@ -216,5 +216,10 @@
<div class="adoc-content" th:replace="doc:XXE_mitigation.adoc"></div>
</div>
<div class="lesson-page-wrapper">
<div class="adoc-content" th:replace="doc:XXE_static_code_analysis.adoc"></div>
<a href="/WebGoat/xxe/applysecurity" onclick="javascript:return false;">Apply XXE security patch</a>
</div>
</html>

Binary file not shown.

After

Width:  |  Height:  |  Size: 89 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 41 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 60 KiB

View File

@ -0,0 +1,21 @@
=== Find XXE issues with static code analysis
Static code analysis can help identify vulnerabilities in code. A well known tool for static code analysis is SonarQube. When you run a code scan on the source code of WebGoat, you will get something like:
image::images/sonar-issues.png[Sonar OWASP issues,300,200]
If you select the XXE category it will show you the location of the XXE vulnerability.
image::images/sonar-issue-xxe.png[XXE issue in Comments class]
The next step is to identify whether this is a true issue or a false positive. As you already know from the challenge exercise, this is a real issue. In this case it is put in intentionally.
SonarQube also shows you what you could do to fix this.
image::images/xxe-suggested-fix.png[XXE suggested fix]
If you click on the link below, you can try to do the XXE challenges again and you will notice that the vulnerabilities are mitigated.