dubey/WebGoat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix warnings

Browse Source 
git-svn-id: http://webgoat.googlecode.com/svn/trunk@185 4033779f-a91e-0410-96ef-6bf7bf53c507
This commit is contained in:
rogan.dawes
2007-07-18 13:31:42 +00:00
parent 9ea97126b8
commit d709ff9506
4 changed files with 1 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
webgoat/main/project/JavaSource/org/owasp/webgoat/lessons/CommandInjection.java
View File

@ -14,7 +14,6 @@ import org.apache.ecs.html.BR;
import org.apache.ecs.html.HR;
import org.apache.ecs.html.IMG;
import org.apache.ecs.html.P;
import org.apache.ecs.html.PRE;
import org.owasp.webgoat.session.ECSFactory;
import org.owasp.webgoat.session.WebSession;
@ -76,7 +75,6 @@ public class CommandInjection extends LessonAdapter
{
String helpFile = s.getParser().getRawParameter(HELP_FILE,
"BasicAuthentication.help");
String safeDirName;
if (getWebgoatContext().isDefuseOSCommands()
&& (helpFile.indexOf('&') != -1 || helpFile.indexOf(';') != -1))
{
@ -134,8 +132,7 @@ public class CommandInjection extends LessonAdapter
if (upDirCount(helpFile) <= 3)
{
// FIXME: This value isn't used. What is the goal here?
safeDirName = s.getContext().getRealPath("/")
+ helpFile;
s.getContext().getRealPath("/");
illegalCommand = false;
}
else
@ -295,31 +292,6 @@ public class CommandInjection extends LessonAdapter
return (er.toString());
}
/**
* Description of the Method
*
* @param command Description of the Parameter
* @param args Description of the Parameter
* @param s Description of the Parameter
* @return Description of the Return Value
*/
private Element exec(WebSession s, String command, String args)
{
System.out.println("Executing OS command: '" + command
+ "' with args: '" + args + "'");
ExecResults er = Exec.execSimple(command, args);
if ((args.indexOf("&") != -1 || args.indexOf(";") != -1)
&& !er.getError())
{
makeSuccess(s);
}
PRE p = new PRE().addElement(er.toString());
return (p);
}
/**
* Gets the category attribute of the CommandInjection object
*