From dea4a9d2a9a7357342642ff127bf48b66bb22009 Mon Sep 17 00:00:00 2001
From: avivmu <aviv.mu@gmail.com>
Date: Mon, 11 Jan 2021 17:38:14 +0200
Subject: [PATCH] Small improvements (#918)
* Typo fix
* No need to use thread-safe object
* Use String case in-sensitive equals
---
.../org/owasp/webgoat/http_basics/HttpBasicsLesson.java | 4 ++--
.../java/org/owasp/webgoat/http_basics/HttpBasicsQuiz.java | 6 +++---
.../main/resources/lessonPlans/en/IntroductionWebWolf.adoc | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/webgoat-lessons/http-basics/src/main/java/org/owasp/webgoat/http_basics/HttpBasicsLesson.java b/webgoat-lessons/http-basics/src/main/java/org/owasp/webgoat/http_basics/HttpBasicsLesson.java
index 25b2215d8..ac935c5f8 100644
--- a/webgoat-lessons/http-basics/src/main/java/org/owasp/webgoat/http_basics/HttpBasicsLesson.java
+++ b/webgoat-lessons/http-basics/src/main/java/org/owasp/webgoat/http_basics/HttpBasicsLesson.java
@@ -34,10 +34,10 @@ public class HttpBasicsLesson extends AssignmentEndpoint {
@PostMapping("/HttpBasics/attack1")
@ResponseBody
public AttackResult completed(@RequestParam String person) {
- if (!person.equals("")) {
+ if (!person.isBlank()) {
return success(this)
.feedback("http-basics.reversed")
- .feedbackArgs(new StringBuffer(person).reverse().toString())
+ .feedbackArgs(new StringBuilder(person).reverse().toString())
.build();
} else {
return failed(this).feedback("http-basics.empty").build();
diff --git a/webgoat-lessons/http-basics/src/main/java/org/owasp/webgoat/http_basics/HttpBasicsQuiz.java b/webgoat-lessons/http-basics/src/main/java/org/owasp/webgoat/http_basics/HttpBasicsQuiz.java
index 913fed785..695991856 100644
--- a/webgoat-lessons/http-basics/src/main/java/org/owasp/webgoat/http_basics/HttpBasicsQuiz.java
+++ b/webgoat-lessons/http-basics/src/main/java/org/owasp/webgoat/http_basics/HttpBasicsQuiz.java
@@ -38,11 +38,11 @@ public class HttpBasicsQuiz extends AssignmentEndpoint {
@PostMapping("/HttpBasics/attack2")
@ResponseBody
- public AttackResult completed(@RequestParam String answer, @RequestParam String magic_answer, @RequestParam String magic_num) throws IOException {
- if ("POST".equals(answer.toUpperCase()) && magic_answer.equals(magic_num)) {
+ public AttackResult completed(@RequestParam String answer, @RequestParam String magic_answer, @RequestParam String magic_num) {
+ if ("POST".equalsIgnoreCase(answer) && magic_answer.equals(magic_num)) {
return success(this).build();
} else {
- if (!"POST".equals(answer.toUpperCase())) {
+ if (!"POST".equalsIgnoreCase(answer)) {
return failed(this).feedback("http-basics.incorrect").build();
}
if (!magic_answer.equals(magic_num)) {
diff --git a/webgoat-lessons/webwolf-introduction/src/main/resources/lessonPlans/en/IntroductionWebWolf.adoc b/webgoat-lessons/webwolf-introduction/src/main/resources/lessonPlans/en/IntroductionWebWolf.adoc
index 3b817e7f7..b29ae401a 100644
--- a/webgoat-lessons/webwolf-introduction/src/main/resources/lessonPlans/en/IntroductionWebWolf.adoc
+++ b/webgoat-lessons/webwolf-introduction/src/main/resources/lessonPlans/en/IntroductionWebWolf.adoc
@@ -1,7 +1,7 @@
== Introducing WebWolf
You only need WebWolf if a lesson specifies you can use it. For a lot of lessons you use WebGoat without
-starting WebWolf. If you need to do an exercise with WebWolf make sure it is running along side WebGoat. Lessons
+starting WebWolf. If you need to do an exercise with WebWolf make sure it is running alongside WebGoat. Lessons
where you can use WebWolf are marked with the following icon (top right in assignment):
{nbsp}