Use AbstractLesson.getLink() and getFormAction() more
Rather than constructing URL's manually all the time, rather make use of existing mechanisms to create the URL, and use it consistently. git-svn-id: http://webgoat.googlecode.com/svn/trunk@184 4033779f-a91e-0410-96ef-6bf7bf53c507
This commit is contained in:
@ -360,42 +360,7 @@ public class WebSession
|
||||
|
||||
public String getRestartLink()
|
||||
{
|
||||
List<String> parameters = new ArrayList<String>();
|
||||
|
||||
String screenValue = request.getParameter(SCREEN);
|
||||
if (screenValue != null)
|
||||
parameters.add(SCREEN + "=" + screenValue);
|
||||
|
||||
String menuValue = request.getParameter(MENU);
|
||||
if (menuValue != null)
|
||||
parameters.add(MENU + "=" + menuValue);
|
||||
|
||||
parameters.add(RESTART + "=" + currentScreen);
|
||||
|
||||
return makeQuery("attack", parameters);
|
||||
}
|
||||
|
||||
private String makeQuery(String resource, List parameters)
|
||||
{
|
||||
StringBuffer query = new StringBuffer(resource);
|
||||
|
||||
boolean isFirstParameter = true;
|
||||
Iterator i = parameters.iterator();
|
||||
|
||||
while (i.hasNext())
|
||||
{
|
||||
String parameter = (String) i.next();
|
||||
if (isFirstParameter)
|
||||
{
|
||||
query.append("?");
|
||||
isFirstParameter = false;
|
||||
}
|
||||
else
|
||||
query.append("&");
|
||||
query.append(parameter);
|
||||
}
|
||||
|
||||
return query.toString();
|
||||
return getCurrentLesson().getLink() + "&" + RESTART + "=" + getCurrentScreen();
|
||||
}
|
||||
|
||||
public String getCurrentLink()
|
||||
|
Reference in New Issue
Block a user